Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: refactor/update newer vulkan memory allocator #59

Conversation

pollend
Copy link
Contributor

@pollend pollend commented Feb 7, 2022

I ended up moving things into wrappers so it was easier to update the api without updating fields and having to map those values in the binding and passing them over the foreign function interface. should make the process of updating the API easier in the future. I also fixed the unit test but I think I'm probably missing functions from the VulkanMemoryAllocator but this is still a bit of a wip.

examples:

 let create_info = vk_mem::AllocatorCreateInfo::new(&self.instance, &self.device, &self.physical_device);
 let allocator = vk_mem::Allocator::new(create_info).unwrap()

---

 let mut allocation_info = vk_mem::AllocationCreateInfo::new()
        .required_flags(ash::vk::MemoryPropertyFlags::HOST_VISIBLE)
        .preferred_flags(ash::vk::MemoryPropertyFlags::HOST_COHERENT
            | ash::vk::MemoryPropertyFlags::HOST_CACHED)
        .flags(vk_mem::AllocationCreateFlags::MAPPED);

- update version of VulkanMemoryAllocator
- fixed unit test
- update api and remove extra copy for device and Instance
@pollend pollend changed the title Feature/update newer vulkan memory allocator feature: refactor/update newer vulkan memory allocator Feb 7, 2022
@gwihlidal gwihlidal merged commit 0be8984 into gwihlidal:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants