Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE1-1809] feat(k8s): throw error for invalid function associations #107

Merged
merged 1 commit into from
Oct 17, 2023
Merged

[PE1-1809] feat(k8s): throw error for invalid function associations #107

merged 1 commit into from
Oct 17, 2023

Conversation

LCaparelli
Copy link
Member

Description

Depends on #105 and #106

  • $TITLE
  • throw a warning event if using deprecated annotations, even if valid

Motivation and Context

Refer to #105

How has this been tested?

Validated all error paths and checked events on Ingress.

Checklist

  • I have implemented automated tests for the changes.
  • I have updated the documentation accordingly.

@LCaparelli LCaparelli mentioned this pull request Oct 10, 2023
Merged
5 tasks
@LCaparelli LCaparelli force-pushed the PE1-1809/function-associations-validation branch from 5d28c42 to f7d9859 Compare October 16, 2023 18:18
@LCaparelli LCaparelli force-pushed the PE1-1809/function-associations-validation branch from f7d9859 to 7066150 Compare October 17, 2023 14:51
@LCaparelli LCaparelli merged commit 18a1c79 into develop Oct 17, 2023
@LCaparelli LCaparelli deleted the PE1-1809/function-associations-validation branch October 17, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caiofralmeida caiofralmeida caiofralmeida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LCaparelli @caiofralmeida