Xorg compat #502
Merged
Xorg compat #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quitschbo
force-pushed
the
xorg_compat
branch
4 times, most recently
from
449eeac to
b3ab381
Compare
Recent Linux kernel 6.9 changed device link of parent devices in the sysfs. Newer xorg servers can handle this. However, to be compatible with container payload which includes no recent xorg server, we introduce this module. It will mount a tmpfs on the /sys/class/graphics directory and links the included files, so that it will compatible with old matching logic. Especially, the link in /sys/class/graphics/fb0 may not include a pci suffix to get recognized as platform device by legacy xorg servers. Thus we link to bus/platform instead. Signed-off-by: Michael Weiß <[email protected]>
Instead of unconditionally enable compat code, do this conditionally if the new flag COMPARTMENT_FLAG_XORG_COMPAT is set for this compartment. Signed-off-by: Michael Weiß <[email protected]>
Introduce the config field 'enable_xorg_compat' to enable or disable (default) the xorg_compat submodule for this container at runtime. Wire up the corresponding container source files from container.proto through container_config.c to container.c. Signed-off-by: Michael Weiß <[email protected]>
Since now the actual runtime compat code can be enabled by a flag in the container config, Set XORG_COMPAT=y in Makefile. Thus, the xorg compat module itself is enabled at compile time. Signed-off-by: Michael Weiß <[email protected]>
quitschbo
force-pushed
the
xorg_compat
branch
from
b3ab381 to
dba6cdd
Compare
jwsbck
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent Linux kernel 6.9 changed device link of parent devices
in the sysfs. Newer xorg servers can handle this. However, to be
compatible with container payload which includes no recent xorg
server, we introduce this module. It will mount a tmpfs on the
/sys/class/graphics directory and links the included files, so
that it will compatible with old matching logic.
Especially, the link in /sys/class/graphics/fb0 may not include
a pci suffix to get recognized as platform device by legacy xorg
servers. Thus we link to bus/platform instead.