common/Makefile: Fix dependencies for audit.proto #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0ch4lo
force-pushed
the
libcommon_makefile_fix_protobuf
branch
11 times, most recently
from
a990a47 to
62c9b9f
Compare
quitschbo
force-pushed
the
libcommon_makefile_fix_protobuf
branch
from
62c9b9f to
72a263c
Compare
k0ch4lo
force-pushed
the
libcommon_makefile_fix_protobuf
branch
from
72a263c to
a5734a2
Compare
This commit adapts the target dependencies for compilation of audit.proto in common/Makefile
to ensure the 'protobuf' target actually provides audit.pb-c.{h,c}.
This fixes races during build:
make -C common protobuf
| make[1]: Entering directory /dir/service-static-1.0+999/common'
| protoc-c --c_out=. audit.proto
| In file included from audit.c:28:
| audit.h:32:10: fatal error: audit.pb-c.h: No such file or directory
| 32 | #include "audit.pb-c.h"
| | ^~~~~~~~~~~~~~
Signed-off-by: Felix Wruck <[email protected]>
quitschbo
force-pushed
the
libcommon_makefile_fix_protobuf
branch
from
a5734a2 to
6d7d62b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the target dependencies for compilation of audit.proto in common/Makefile to ensure the 'protobuf' target actually provides audit.pb-c.{h,c}.
This fixes races during build:
make -C common protobuf
| make[1]: Entering directory /dir/service-static-1.0+999/common' | protoc-c --c_out=. audit.proto
| In file included from audit.c:28:
| audit.h:32:10: fatal error: audit.pb-c.h: No such file or directory
| 32 | #include "audit.pb-c.h"
| | ^~~~~~~~~~~~~~