common/file: Fix handling of non-regular files in file_copy #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPeisl
force-pushed
the
feature/sendfile
branch
7 times, most recently
from
f5df6ff to
fc7c7f0
Compare
In file_copy, the input file size got calculated using the min of fstat(2) and the provided count*bs. For non-regular files like /dev/zero this lead to wrong behaviour as fstat reports 0 for such files. Now, for positive counts always count*bs is taken as input file size. In case a write operation returns 0 it is assumed that no input data is left for copying. Signed-off-by: Maximilian Peisl <[email protected]>
MPeisl
force-pushed
the
feature/sendfile
branch
from
fc7c7f0 to
b832eec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In file_copy, the input file size got calculated using the min of fstat(2) and the provided countbs. For non-regular files like /dev/zero this lead to wrong behaviour as fstat reports 0 for such files. Now, for positive counts always countbs is taken as input file size. In case a write operation returns 0 it is assumed that no input data is left for copying.