Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosConfiguration escape hatch #14

Closed
blaggacao opened this issue Apr 7, 2021 · 6 comments
Closed

nixosConfiguration escape hatch #14

blaggacao opened this issue Apr 7, 2021 · 6 comments

Comments

@blaggacao
Copy link
Collaborator

blaggacao commented Apr 7, 2021

, nixosConfigurations ? { }

It is not entirely clear or self evident why fup should provide this service.

Sure, it is nice to have, but it is also only a // nixosConfigurations away in the top level flake.

/cc @Pacman99

blaggacao pushed a commit to blaggacao/flake-utils-plus that referenced this issue Apr 7, 2021
@blaggacao blaggacao mentioned this issue Apr 7, 2021
@Pacman99
Copy link
Collaborator

Pacman99 commented Apr 7, 2021

It might be for backward compatibility. Also perhaps it could be useful to still get module args(nixpkgs) and other things, but I don't think thats done at the moment.

@gytis-ivaskevicius
Copy link
Owner

Responded with the reasoning of it in the PR itself

@blaggacao
Copy link
Collaborator Author

Suggestion in the PR looks like a better fix for this. The main motive was to get this out of the function signature, but it can be passed and lib.recursiveUpdated as a friendly service from fup , still via ....

@Pacman99
Copy link
Collaborator

Pacman99 commented Apr 7, 2021

Is there any need for an escape hatch? I have read a few flakes that use this repo, and I don't think any use this escape hatch. If your going to use flake-utils-plus, I can't see a reason to make your own configuration and that being easier than using nixosProfiles. If someone wants to do something custom, they can just do it within their own flake.

And flake-utils-plus is already so general and clean, that an escape hatch seems very extra to me.

@gytis-ivaskevicius
Copy link
Owner

Yeah, maybe you are right

@blaggacao
Copy link
Collaborator Author

This has been dealt with in #17 (via deprecation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants