Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles #16

Closed
blaggacao opened this issue Apr 7, 2021 · 6 comments
Closed

profiles #16

blaggacao opened this issue Apr 7, 2021 · 6 comments

Comments

@blaggacao
Copy link
Collaborator

blaggacao commented Apr 7, 2021

, nixosProfiles ? { }

nixosProfiles do contain system profiles, in a sense, but more accurately they contain host configs.

This clashes with devos' usage of the term profiles which is reserved for a very special meaning:

  • profiles cannot declare options, but only make use of them. (while anything that declares options are modules)
  • this rule makes modules a lot more reusable among the community

With fup reserving the name, we might have a problem finding an alternative naming scheme. (and also it's somewhat established, already)

/cc @Pacman99

@nrdxp
Copy link

nrdxp commented Apr 7, 2021

FWIW, I got the term "profiles" directly from the nixpkgs module directory where it is already being used in this fashion.

@blaggacao blaggacao mentioned this issue Apr 7, 2021
@gytis-ivaskevicius
Copy link
Owner

I am quite a fan of the name profiles for this particular use case and you must suggest quite a bit more attractive naming for this particular case for me to change it.

Also, may I add that I've seen several repos with profiles folder which represents the same thing as flake-utils-plus do.

@blaggacao
Copy link
Collaborator Author

blaggacao commented Apr 7, 2021

Hm, @gytis-ivaskevicius that does not solve my (our) problem. Would you care and try to find a negotiated consensus solution?

From devos' perspective, there are no alternative namings available.

We are trying to catch the same trout, here.

👎 for closing. 😉

One obvious suggestion would be either nixosHosts or nixosHostProfiles.

Both would preserve upstream usage semantics of the single word "profiles".

Also, may I add that I've seen several repos with profiles folder which represents the same thing as flake-utils-plus do.

We would care less how people actually name their folders. The goal is to wrap fup and implement a strict superset of its function api. That means the function api namespace is a shared one.

As I had understood it the goal of fup is to be generally useful and even become upstreamed into fu. So the function args namespace it consumes is of greater interest.

@gytis-ivaskevicius
Copy link
Owner

Alright, this will be fixed using the name nixosHosts as part of the wrapper function for time being until we finalize the API

@blaggacao
Copy link
Collaborator Author

Thank you! Much appreciated. 👍

blaggacao pushed a commit that referenced this issue Apr 7, 2021
nixosProfiles might conflict a little too much with downstream naming.
blaggacao pushed a commit that referenced this issue Apr 7, 2021
nixosProfiles might conflict a little too much with downstream naming.
@blaggacao
Copy link
Collaborator Author

closed in #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants