Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation for Extended Features with subleaf Ecx=0x1 #182

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Implementation for Extended Features with subleaf Ecx=0x1 #182

merged 2 commits into from
Jul 24, 2024

Conversation

mert-kurttutan
Copy link
Contributor

  • Implementations
  • Tests and cli are modified accordingly.

@mert-kurttutan
Copy link
Contributor Author

The tests for xeon_gold and ryzen include already recorded information about their bit values.
But I dont have access to those machine so I dont know the values. I just set all the fields to 0 bit. And, tests for those dont include test-case for new features since I dont know which value they should take.

@mert-kurttutan
Copy link
Contributor Author

mert-kurttutan commented Jul 24, 2024 •
edited
Loading

Just letting you know in case you want to me modify anything in the PR

@gz gz merged commit a683490 into gz:master Jul 24, 2024
2 of 3 checks passed
@gz
Copy link
Owner

gz commented Jul 24, 2024

lgtm thanks!

This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gz gz gz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mert-kurttutan @gz