node: require LocalAppData variable (ethereum#19132)

gzliudan · Nov 8, 2024 · 32c7a78 · 32c7a78
1 parent feb211e
commit 32c7a78
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/node/defaults.go b/node/defaults.go
@@ -78,13 +78,14 @@ func DefaultDataDir() string {
 }
 
 func windowsAppData() string {
-	if v := os.Getenv("LOCALAPPDATA"); v != "" {
-		return v // Vista+
+	v := os.Getenv("LOCALAPPDATA")
+	if v == "" {
+		// Windows XP and below don't have LocalAppData. Crash here because
+		// we don't support Windows XP and undefining the variable will cause
+		// other issues.
+		panic("environment variable LocalAppData is undefined")
 	}
-	if v := os.Getenv("APPDATA"); v != "" {
-		return filepath.Join(v, "Local")
-	}
-	return ""
+	return v
 }
 
 func isNonEmptyDir(dir string) bool {