Try2 increase code coverage #290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sescandor
commented
Mar 6, 2020
sescandor
commented
- Create a fuzz target for address token encryption.
- Fix heap buffer overflow found by address token encryption fuzzer.
- Add address token encryption fuzz target to CMakeLists.txt.
…n plaintext is less than our assumed size of quicly_address_token_plaintext_t
kazuho
reviewed
Mar 6, 2020
| int ret = 0; | ||
|
|
||
| if (start_off < sizeof(quicly_address_token_plaintext_t)) | ||
| goto Exit; |
There was a problem hiding this comment.
I am not sure if this change is necessary. start_off does not have any relationship with quicly_address_token_plaintext_t.
As stated in the doc-comment of the doc-comment of the function declaration, the role of the function is to append token to the buffer being provided, considering bytes between start_off and buf->off as AAD.
Also, the function is expected to return an error code (0 means success). I'd assume that this is an error case?
| ptls_aead_context_t *enc = ptls_aead_new(&ptls_openssl_aes128gcm, &ptls_openssl_sha256, 1, zero_key, ""); | ||
| ptls_buffer_init(&buf, b, 0); | ||
|
|
||
| quicly_encrypt_address_token(ptls_openssl_random_bytes, enc, &buf, Size, (quicly_address_token_plaintext_t *)Data); |
There was a problem hiding this comment.
I am not sure if we can or need to fuzz quicly_address_token_plaintext_t, as is not an input from the network. It is a local structure being built with certain restricitons (e.g., quicly_address_t containing a valid sockaddr).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.