Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 62-bit error codes #602

Merged
merged 23 commits into from
Jan 12, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert excess change
kazuho committed Jan 11, 2025
commit 0f3928021ab19ba2ef5a2d534fef7cbd8bf03b9a
4 changes: 2 additions & 2 deletions lib/quicly.c
Original file line number Diff line number Diff line change
@@ -3069,7 +3069,7 @@ static int64_t do_on_ack_ack(quicly_conn_t *conn, const quicly_sent_packet_t *pa
}

/* subtract given ACK ranges */
int64_t ret;
int ret;
uint64_t end = start + start_length;
if ((ret = quicly_ranges_subtract(&space->ack_queue, start, end)) != 0)
return ret;
@@ -3117,12 +3117,12 @@ static int64_t on_ack_ack_ranges8(quicly_sentmap_t *map, const quicly_sent_packe
static int64_t on_ack_stream_ack_one(quicly_conn_t *conn, quicly_stream_id_t stream_id, quicly_sendstate_sent_t *sent)
{
quicly_stream_t *stream;
int64_t ret;

if ((stream = quicly_get_stream(conn, stream_id)) == NULL)
return 0;

size_t bytes_to_shift;
int ret;
if ((ret = quicly_sendstate_acked(&stream->sendstate, sent, &bytes_to_shift)) != 0)
return ret;
if (bytes_to_shift != 0) {