chore: Prevent multiple portals from being created #2025

h2oai · Sep 6, 2023 · 9582558 · 9582558
1 parent ad785cd
commit 9582558
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/ui/src/copyable_text.tsx b/ui/src/copyable_text.tsx
@@ -79,6 +79,7 @@ export const ClipboardCopyButton = ({ value, anchorElement, showOnHoverOnly = fa
   const
     timeoutRef = React.useRef<U>(),
     [copied, setCopied] = React.useState(false),
+    btnContainerRef = React.useRef<HTMLDivElement>(document.createElement('div')),
     onClick = React.useCallback(async () => {
       if (!anchorElement) return
       try {
@@ -105,10 +106,9 @@ export const ClipboardCopyButton = ({ value, anchorElement, showOnHoverOnly = fa
   React.useEffect(() => {
     if (!anchorElement) return
     if (portal) {
-      // TODO: Prevent multiple portals from being created, e.g. when showOnHoverOnly prop changes.
       ReactDOM.render(
         ReactDOM.createPortal(CopyButton, anchorElement),
-        document.createElement('div')
+        btnContainerRef.current
       )
     }
     if (showOnHoverOnly) anchorElement.classList.add(css.hover)