chore: remove button render tests, improve button visibility on dark …

…backgrounds #2025
h2oai · Sep 6, 2023 · 9955eae · 9955eae
1 parent fecbc74
commit 9955eae
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 17 deletions.
diff --git a/ui/src/copyable_text.test.tsx b/ui/src/copyable_text.test.tsx
@@ -35,14 +35,6 @@ describe('CopyableText.tsx', () => {
     expect(getByTestId(name)).toHaveValue('B')
   })
 
-  it('Shows copy to clipboard button', () => {
-    const { container } = render(<XCopyableText model={copyableTextProps} />)
-    const copyButton = container.querySelector('button')
-
-    expect(copyButton).toBeInTheDocument()
-    expect(copyButton).toBeVisible()
-  })
-
   it('Shows copy to clipboard button on hover - multiline text', async () => {
     const { container } = render(<XCopyableText model={{ ...copyableTextProps, multiline: true }} />)
     await new Promise(resolve => setTimeout(resolve, 500))

diff --git a/ui/src/copyable_text.tsx b/ui/src/copyable_text.tsx
@@ -26,6 +26,9 @@ const
       right: CORNER_OFFSET,
       width: BUTTON_WIDTH,
       height: BUTTON_HEIGHT,
+      outlineWidth: 1,
+      outlineStyle: 'solid',
+      outlineColor: cssVar('$white')
     },
     copiedBtn: {
       background: cssVar('$green'),

diff --git a/ui/src/markdown.test.tsx b/ui/src/markdown.test.tsx
@@ -66,13 +66,4 @@ describe('Markdown.tsx', () => {
     userEvent.hover(textfield)
     expect(container.querySelector('button')).toBeVisible()
   })
-
-  it('Does not render copy to clipboard button - markdown without code block', async () => {
-    const { container } = render(<Markdown source={source} />)
-    await new Promise(resolve => setTimeout(resolve, 500))
-
-    const copyButton = container.querySelector('button')
-
-    expect(copyButton).not.toBeInTheDocument()
-  })
 })