Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Table grouped incorrectly after rows change #1724

Merged
merged 7 commits into from
Dec 7, 2022
Merged

Conversation

marek-mihok
Copy link
Contributor

@marek-mihok marek-mihok commented Nov 28, 2022

This PR makes sure table is reset after table rows change.

Screen.Recording.2022-12-05.at.14.04.46.mov

Closes #1687

@marek-mihok marek-mihok marked this pull request as ready for review December 5, 2022 13:05
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marek-mihok. Please make sure all the unit tests pass.

ui/src/table.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tables Become Incorrectly Grouped in Meta/Dialog (Wave v0.16 --> v0.22+)
2 participants