Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added enter handler for textbox #372 #2355

Closed
wants to merge 1 commit into from
Closed

Conversation

haneenabdo
Copy link

@haneenabdo haneenabdo commented Jun 21, 2024

Closes #372
The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@haneenabdo haneenabdo requested review from lo5 and mturoci as code owners June 21, 2024 19:08
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haneenabdo! Can you pleases also include unit tests and a video demo of how your changes work in practice?

Comment on lines +15 to +20
"paths": {
"@fluentui/react": ["node_modules/@fluentui/react"]
},
"jsx": "preserve",
"esModuleInterop": true,
"include": ["src", "node_modules/@types"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Comment on lines +70 to +71
/**T rue if the Enter button is being pressed */
onEnter?: B
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably do this by default, no need for an extra prop.

@michaeltraxler
Copy link

I would be really happy if this PR would be committed, as I also really need the feature, that pressing Enter in a textbox will call the handler (do something with the contents). An additional button just for this is really not what the people will expect and slow in our environment.

@mturoci
Copy link
Collaborator

mturoci commented Aug 6, 2024

Closing as inactive.

@mturoci mturoci closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add enter handler for textbox
3 participants