Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fragment IDs should scroll to section/article #143

Closed
sideshowbarker opened this issue Feb 29, 2012 · 2 comments
Closed

Fragment IDs should scroll to section/article #143

sideshowbarker opened this issue Feb 29, 2012 · 2 comments
Labels
site

Comments

@sideshowbarker
Copy link
Contributor

Following a link to e.g. http://html5please.com/#localstorage takes me to the top of the page. That’s harsh for UX, especially on mobile. Would seem much better for it to take me down the page to where the actual section/article for localStorage is.
@nimbupani
Copy link
Member

There is still an issue with scrolling when the "tell me more" is open. #145

laurens pushed a commit to laurens/html5please that referenced this issue Mar 2, 2012
Adding scrolling to the expanded features, when clicking on the hashe…
94c98c0 
…s or going straight from the url. It scrolls to the explore features heading slightly smoothly. Fixes h5bp#143
@nimbupani nimbupani reopened this Mar 5, 2012
@nimbupani
Copy link
Member

Apparently my fix is not good enough, reopening until someone provides a better fix.

laurens added a commit to laurens/html5please that referenced this issue Mar 6, 2012
@laurens
Page will scroll, if the feature list contains items matching the has…
21de664 
…h/fragment or search query. Remix of #36f3749

Implemeted scrollToElement() function for scrolling to specific dom element. Fixed getYOffset() function. Fixes h5bp#143 Fixes h5bp#145. However, someone should test if scroll performance is acceptable.
@laurens laurens mentioned this issue Mar 6, 2012
Closed
@robwierzbowski robwierzbowski mentioned this issue Dec 15, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
site
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Page scroll #143 laurens/html5please
3 participants
@nimbupani @sideshowbarker @arthurvr