Update audio element #452
Merged
Update audio element #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for html5please ready! Built with commit 08ea176 |
coliff
requested changes
Mar 5, 2019
There was a problem hiding this comment.
As is the case with video, you can provide your audio in multiple formats. But it’s not necessary if you only target modern browsers.
See browser media codec support in 2018, or mdn browser compatibility tables.
- typo: compatibility
- minor change to first sentence as multiple formats is more than one audio file
- simplify second sentence
|
Thanks Christian 🙇 Updated the post and going to squash and merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #409