Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: how to prevent closing challenge upon back press #132

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Oct 19, 2023

@CAMOBAP CAMOBAP self-assigned this Oct 19, 2023
@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────
      jar │  50.1 KiB │  50.1 KiB │ +41 B 
 manifest │     457 B │     457 B │   0 B 
      res │  78.3 KiB │  78.3 KiB │   0 B 
    other │  75.8 KiB │  75.8 KiB │   0 B 
──────────┼───────────┼───────────┼───────
    total │ 204.5 KiB │ 204.6 KiB │ +41 B 

 JAR     │ old │ new │ diff      
─────────┼─────┼─────┼───────────
 classes │  37 │  37 │ 0 (+0 -0) 
 methods │ 500 │ 500 │ 0 (+0 -0) 
  fields │ 160 │ 160 │ 0 (+0 -0)
AAR
 size     │ diff  │ path          
──────────┼───────┼───────────────
 50.1 KiB │ +41 B │ ∆ classes.jar 
──────────┼───────┼───────────────
 50.1 KiB │ +41 B │ (total)

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +144.27 0
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +147.81 +95
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup -1.06 +88
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo +7.52 +2
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +16.37 0
com.hcaptcha.sdk.HCaptchaWebViewHelperTest.EMULATOR_UNLOCKED_benchmarkWebViewLoad +104.78 +94

@CAMOBAP CAMOBAP requested review from e271828- and DSergiu October 19, 2023 14:22
@CAMOBAP CAMOBAP marked this pull request as ready for review October 19, 2023 14:22
@DSergiu DSergiu changed the title Feature/ignore back press feat: config to ignore back press Oct 19, 2023
@DSergiu DSergiu changed the title feat: config to ignore back press feat(sdk): config to ignore back press Oct 19, 2023
@CAMOBAP CAMOBAP force-pushed the feature/ignore-back-press branch from 155ef3c to 13cb514 Compare October 19, 2023 18:24
@CAMOBAP CAMOBAP requested a review from DSergiu October 19, 2023 18:24
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@DSergiu DSergiu changed the title feat(sdk): config to ignore back press docs: how to prevent closing challenge upon back press Oct 19, 2023
@DSergiu DSergiu merged commit a75cc04 into main Oct 24, 2023
11 checks passed
@DSergiu DSergiu deleted the feature/ignore-back-press branch October 24, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants