Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missleading missing sitekey message #137

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Dec 15, 2023

No description provided.

@CAMOBAP CAMOBAP requested a review from DSergiu December 15, 2023 11:30
@CAMOBAP CAMOBAP self-assigned this Dec 15, 2023
Copy link

github-actions bot commented Dec 15, 2023

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────
      jar │  51.9 KiB │  51.9 KiB │ +32 B 
 manifest │     411 B │     411 B │   0 B 
      res │  78.3 KiB │  78.3 KiB │   0 B 
    other │     814 B │     814 B │   0 B 
──────────┼───────────┼───────────┼───────
    total │ 131.3 KiB │ 131.4 KiB │ +32 B 

 JAR     │ old │ new │ diff       
─────────┼─────┼─────┼────────────
 classes │  37 │  37 │  0 (+0 -0) 
 methods │ 507 │ 507 │  0 (+0 -0) 
  fields │ 164 │ 163 │ -1 (+0 -1)
AAR
 size     │ diff  │ path          
──────────┼───────┼───────────────
 51.9 KiB │ +32 B │ ∆ classes.jar 
──────────┼───────┼───────────────
 51.9 KiB │ +32 B │ (total)
JAR
FIELDS:

   old │ new │ diff       
  ─────┼─────┼────────────
   164 │ 163 │ -1 (+0 -1) 
  - com.hcaptcha.sdk.HCaptcha TAG: String

Copy link

github-actions bot commented Dec 15, 2023

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +255.06 -4
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +487.94 +99
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup +16.05 +94
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo +186.23 +557
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +97.25 -43
com.hcaptcha.sdk.HCaptchaWebViewHelperTest.EMULATOR_UNLOCKED_benchmarkWebViewLoad +72.88 +95

Copy link

@DSergiu DSergiu changed the title Bugfix/missleading missing sitekey message fixmissleading missing sitekey message Dec 15, 2023
@DSergiu DSergiu changed the title fixmissleading missing sitekey message fix: missleading missing sitekey message Dec 15, 2023
@CAMOBAP CAMOBAP merged commit f01f3b4 into main Dec 22, 2023
12 checks passed
@CAMOBAP CAMOBAP deleted the bugfix/missleading-missing-sitekey-message branch December 22, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants