Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop diagnostic logs from production code #139

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Dec 15, 2023

There isn't much benefit in having this in production and removing it reduces the final APK size a bit

UPD:

  • -556bytes on sample app apk
  • less stress on logcat

There isn't much benefit in having this in production and removing it reduces the final APK size a bit
@CAMOBAP CAMOBAP requested a review from DSergiu December 15, 2023 14:37
@CAMOBAP CAMOBAP self-assigned this Dec 15, 2023
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────
      jar │  51.9 KiB │  51.9 KiB │    0 B 
 manifest │     411 B │     411 B │    0 B 
      res │  78.3 KiB │  78.3 KiB │    0 B 
    other │     814 B │     930 B │ +116 B 
──────────┼───────────┼───────────┼────────
    total │ 131.3 KiB │ 131.5 KiB │ +116 B 

 JAR     │ old │ new │ diff      
─────────┼─────┼─────┼───────────
 classes │  37 │  37 │ 0 (+0 -0) 
 methods │ 507 │ 507 │ 0 (+0 -0) 
  fields │ 164 │ 164 │ 0 (+0 -0)
AAR
 size  │ diff   │ path           
───────┼────────┼────────────────
 601 B │ +116 B │ ∆ proguard.txt 
───────┼────────┼────────────────
 601 B │ +116 B │ (total)

@DSergiu DSergiu changed the title feature: drop diagnostic logs from production code feat: drop diagnostic logs from production code Dec 15, 2023
Copy link

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +59.93 -6
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +67.98 +95
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup +1.21 +98.75
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo +3.90 +559
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +11.80 -43
com.hcaptcha.sdk.HCaptchaWebViewHelperTest.EMULATOR_UNLOCKED_benchmarkWebViewLoad +64.39 +95

@CAMOBAP CAMOBAP merged commit cca93c1 into main Dec 22, 2023
12 checks passed
@CAMOBAP CAMOBAP deleted the feature/drop-diagnostic-logs-from-production branch December 22, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants