Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle null internal config in args for HCaptchaDialogFragment #140

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Dec 22, 2023

Issue details

Screenshot 2023-12-22 at 4 28 17 PM Screenshot 2023-12-22 at 4 28 56 PM

Explanation

The crash looks like a bug in Android itself. This PR is not to fix the issue but to prevent host app from crashing

Open for discussion, to find a better solution

@CAMOBAP CAMOBAP requested a review from DSergiu December 22, 2023 15:32
@CAMOBAP CAMOBAP self-assigned this Dec 22, 2023
Copy link

Copy link

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────
      jar │  51.9 KiB │  51.8 KiB │ -69 B 
 manifest │     411 B │     411 B │   0 B 
      res │  78.3 KiB │  78.3 KiB │   0 B 
    other │     930 B │     930 B │   0 B 
──────────┼───────────┼───────────┼───────
    total │ 131.5 KiB │ 131.4 KiB │ -69 B 

 JAR     │ old │ new │ diff      
─────────┼─────┼─────┼───────────
 classes │  37 │  37 │ 0 (+0 -0) 
 methods │ 507 │ 507 │ 0 (+0 -0) 
  fields │ 163 │ 163 │ 0 (+0 -0)
AAR
 size     │ diff  │ path          
──────────┼───────┼───────────────
 51.8 KiB │ -69 B │ ∆ classes.jar 
──────────┼───────┼───────────────
 51.8 KiB │ -69 B │ (total)

Copy link

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +113.80 -3
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +88.96 +95
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup +7.66 +100.33
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo +19.56 +560
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +5.95 -43
com.hcaptcha.sdk.HCaptchaWebViewHelperTest.EMULATOR_UNLOCKED_benchmarkWebViewLoad +76.51 +96

@CAMOBAP CAMOBAP merged commit c3ed955 into main Dec 23, 2023
12 checks passed
@CAMOBAP CAMOBAP deleted the bugfix/handle-null-intenal-config branch December 23, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants