Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk)!: allow passing Activity for passive sitekeys #146

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Mar 1, 2024

@CAMOBAP CAMOBAP self-assigned this Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────
      jar │  51.8 KiB │  51.9 KiB │ +4 B 
 manifest │     411 B │     411 B │  0 B 
      res │  78.3 KiB │  78.3 KiB │  0 B 
    other │     930 B │     930 B │  0 B 
──────────┼───────────┼───────────┼──────
    total │ 131.4 KiB │ 131.4 KiB │ +4 B 

 JAR     │ old │ new │ diff      
─────────┼─────┼─────┼───────────
 classes │  37 │  37 │ 0 (+0 -0) 
 methods │ 507 │ 507 │ 0 (+7 -7) 
  fields │ 163 │ 163 │ 0 (+1 -1)
AAR
 size     │ diff │ path          
──────────┼──────┼───────────────
 51.9 KiB │ +4 B │ ∆ classes.jar 
──────────┼──────┼───────────────
 51.9 KiB │ +4 B │ (total)
JAR
METHODS:

   old │ new │ diff      
  ─────┼─────┼───────────
   507 │ 507 │ 0 (+7 -7) 
  + com.hcaptcha.sdk.HCaptcha <init>(Activity, HCaptchaInternalConfig)
  + com.hcaptcha.sdk.HCaptcha getClient(Activity) → HCaptcha
  + com.hcaptcha.sdk.HCaptcha getClient(Activity, HCaptchaInternalConfig) → HCaptcha
  + com.hcaptcha.sdk.HCaptchaDialogFragment startVerification(Activity)
  + com.hcaptcha.sdk.HCaptchaHeadlessWebView <init>(Activity, HCaptchaConfig, HCaptchaInternalConfig, HCaptchaStateListener)
  + com.hcaptcha.sdk.HCaptchaHeadlessWebView startVerification(Activity)
  + com.hcaptcha.sdk.IHCaptchaVerifier startVerification(Activity)
  
  - com.hcaptcha.sdk.HCaptcha <init>(FragmentActivity, HCaptchaInternalConfig)
  - com.hcaptcha.sdk.HCaptcha getClient(FragmentActivity) → HCaptcha
  - com.hcaptcha.sdk.HCaptcha getClient(FragmentActivity, HCaptchaInternalConfig) → HCaptcha
  - com.hcaptcha.sdk.HCaptchaDialogFragment startVerification(FragmentActivity)
  - com.hcaptcha.sdk.HCaptchaHeadlessWebView <init>(FragmentActivity, HCaptchaConfig, HCaptchaInternalConfig, HCaptchaStateListener)
  - com.hcaptcha.sdk.HCaptchaHeadlessWebView startVerification(FragmentActivity)
  - com.hcaptcha.sdk.IHCaptchaVerifier startVerification(FragmentActivity)
  

FIELDS:

   old │ new │ diff      
  ─────┼─────┼───────────
   163 │ 163 │ 0 (+1 -1) 
  + com.hcaptcha.sdk.HCaptcha activity: Activity
  
  - com.hcaptcha.sdk.HCaptcha activity: FragmentActivity

@CAMOBAP CAMOBAP force-pushed the feature/accept-context-in-get-client branch from 759c3bf to fdc7f95 Compare March 2, 2024 09:57
Copy link

github-actions bot commented Mar 2, 2024

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +359.56 -6
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +563.89 +100
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup +1.91 +96.17
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo +6.56 +593
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +35.91 +1
com.hcaptcha.sdk.HCaptchaWebViewHelperTest.EMULATOR_UNLOCKED_benchmarkWebViewLoad +701.35 +97

@CAMOBAP CAMOBAP requested a review from e271828- March 4, 2024 06:42
@CAMOBAP CAMOBAP marked this pull request as ready for review March 4, 2024 06:42
@CAMOBAP
Copy link
Collaborator Author

CAMOBAP commented Mar 4, 2024

@DSergiu for some reason cannot add you as reviewer, could you please have a look also?

Copy link
Contributor

@e271828- e271828- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may require a major version bump.

Copy link
Contributor

@e271828- e271828- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please update docs.

@CAMOBAP
Copy link
Collaborator Author

CAMOBAP commented Mar 4, 2024

I think this may require a major version bump.

Yep, I think the same

Also, please update docs.

On it

@e271828- e271828- self-requested a review March 4, 2024 13:15
@CAMOBAP CAMOBAP requested a review from DSergiu March 4, 2024 14:45
@DSergiu DSergiu changed the title feat: allow initialize SDK with Activity for hideDialog(true) feat(sdk)!: allow passing Activity for passive sitekeys Mar 4, 2024
README.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: e271828- <[email protected]>
Copy link

sonarqubecloud bot commented Mar 4, 2024

@CAMOBAP
Copy link
Collaborator Author

CAMOBAP commented Mar 5, 2024

It starts hanging quite often, looks like a known issue ReactiveCircus/android-emulator-runner#381

@DSergiu DSergiu merged commit 44f1447 into main Mar 5, 2024
11 of 12 checks passed
@DSergiu DSergiu deleted the feature/accept-context-in-get-client branch March 5, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants