-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: compose sdk #149
Merged
Merged
feat: compose sdk #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diffuse report:
AAR
JAR
|
CAMOBAP
force-pushed
the
feature/compose-sdk
branch
from
April 10, 2024 22:27
2572375
to
29f7efa
Compare
…code-quality.gradle
CAMOBAP
force-pushed
the
feature/compose-sdk
branch
from
April 11, 2024 06:02
29f7efa
to
bb94810
Compare
Benchmark report:
|
I will proceed with one repository solution and implement test publishing and
|
…mpose->compose-sdk
CAMOBAP
force-pushed
the
feature/compose-sdk
branch
from
May 17, 2024 15:33
4be95c3
to
16fbe35
Compare
…droid-sdk into feature/compose-sdk
CAMOBAP
force-pushed
the
feature/compose-sdk
branch
from
May 19, 2024 13:06
d02fbdd
to
d21b1b8
Compare
DSergiu
reviewed
May 20, 2024
compose-sdk/src/test/java/com/hcaptcha/sdk/compose/ExampleUnitTest.kt
Outdated
Show resolved
Hide resolved
DSergiu
approved these changes
May 20, 2024
CAMOBAP
force-pushed
the
feature/compose-sdk
branch
3 times, most recently
from
June 12, 2024 12:13
e1f381a
to
17ebeb2
Compare
CAMOBAP
force-pushed
the
feature/compose-sdk
branch
from
June 12, 2024 12:43
17ebeb2
to
8521021
Compare
DSergiu
approved these changes
Jun 26, 2024
DSergiu
approved these changes
Jun 26, 2024
Quality Gate passedIssues Measures |
DSergiu
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open question
jitpack
doesn't allow to customize published dependency names. For now, we havecom.github.hcaptcha:hcaptcha-android-sdk:x.y.z
which will becomecom.github.hcaptcha.hcaptcha-android-sdk:sdk:x.y.z
and one more artifact will be addedcom.github.hcaptcha.hcaptcha-android-sdk:compose:u.v.w
There are two possible solutions to this problem:
jitpack
tomvncentral
or other repositoryhcaptcha-android-jetpack
Both approaches have their benefits and drawbacks:
N1
- no extra repository need and configuration will become more comples (need to find a way to disable jutpack publishing forcompose
module)N2
- build system stays cleanN2
-sdk
andcompose
more isolated, but we cannot share configuration and build system scriptsPersonally to me there is no ideal solution but
N2
looks a bit better