Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build.gradle downgrade to 2.13.5 #171

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Jan 12, 2025

Jackson 2.14 will require Android SDK 26 so downgrading back to 2.13.x

Related: #170

Jackson 2.14 will require Android SDK 26 so downgrading back to 2.13.x
@CAMOBAP CAMOBAP self-assigned this Jan 12, 2025
@CAMOBAP CAMOBAP requested review from e271828- and DSergiu January 12, 2025 16:42
Copy link

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────
      jar │  51.7 KiB │  51.7 KiB │  0 B 
 manifest │     411 B │     411 B │  0 B 
      res │  78.3 KiB │  78.3 KiB │  0 B 
    other │     954 B │     954 B │  0 B 
──────────┼───────────┼───────────┼──────
    total │ 131.3 KiB │ 131.3 KiB │  0 B 

 JAR     │ old │ new │ diff      
─────────┼─────┼─────┼───────────
 classes │  37 │  37 │ 0 (+0 -0) 
 methods │ 507 │ 507 │ 0 (+0 -0) 
  fields │ 162 │ 162 │ 0 (+0 -0)

Copy link

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +360.88 -6
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +419.63 +99
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup -1.46 +94
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo -10.71 +556
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +26.51 -21

@e271828- e271828- merged commit 7ac335f into main Jan 12, 2025
13 checks passed
@e271828- e271828- deleted the bugfix/no-class-def-found-jackson-2.14.x branch January 12, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants