Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spawn log ingester thread in a tokio runtime to fix jobsrv panic #1685

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

mwrock
Copy link
Contributor

@mwrock mwrock commented Dec 22, 2021

While investigating another unrelated issue, I notices that the jobsrvr would panic when uploading build logs to S3 with:

there is no reactor running, must be called from the context of a Tokio 1.x runtime

The job server would restart and the log still made its way to S3 so this error would go largely unnoticed until we got any decent build load which would cause the job server to crash at the end of every build.

This probably came up some time in the last 6 months during a tokio upgrade.

I built and tested the binary on acceptance and validated that the panic does not occur with this fix.

Signed-off-by: Matt Wrock [email protected]

@mwrock mwrock requested a review from sajjaphani as a code owner December 22, 2021 00:26
Copy link
Contributor

@sajjaphani sajjaphani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mwrock mwrock merged commit 674e836 into main Dec 22, 2021
@mwrock mwrock deleted the reactor branch December 22, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants