spawn log ingester thread in a tokio runtime to fix jobsrv panic #1685
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating another unrelated issue, I notices that the jobsrvr would panic when uploading build logs to S3 with:
The job server would restart and the log still made its way to S3 so this error would go largely unnoticed until we got any decent build load which would cause the job server to crash at the end of every build.
This probably came up some time in the last 6 months during a tokio upgrade.
I built and tested the binary on acceptance and validated that the panic does not occur with this fix.
Signed-off-by: Matt Wrock [email protected]