Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activating 'Build Jobs' on package page #1736

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

sajjaphani
Copy link
Contributor

If we navigate to the 'Build Jobs' or 'Settings' page on the package page, the corresponding tab is not active. This change will fix the tab activation.

This 'routerLinkActiveOptions' was removed for the versions tab to be active even after selecting a particular version from the list. The same is true for Build Jobs.

We will investigate how to handle the child's routes to be active later.

Signed-off-by: Phani Sajja [email protected]

@sajjaphani sajjaphani requested a review from mwrock as a code owner May 25, 2022 07:14
Copy link
Contributor

@mwrock mwrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be added to the settings link too?

@sajjaphani sajjaphani merged commit 916fc82 into main Jun 15, 2022
@sajjaphani sajjaphani deleted the psajja/fix-build-job-nav branch June 15, 2022 14:47
@sajjaphani
Copy link
Contributor Author

Not required on the Settings!

chef-expeditor bot pushed a commit that referenced this pull request Jun 16, 2022
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants