builder-api-proxy dependencies updated for LTS-2024 channel
#1827
Conversation
|
@rahulgoel1 @sajjaphani : It seems there is no If you think it's worthwhile adding the job, then I can add the job for that. |
.expeditor/verify.pipeline.yml
Outdated
| # This is done because some of our `hab` packages like `hab-studio` are | ||
| # not available on `LTS-2024` yet. | ||
| - HAB_FALLBACK_CHANNEL=stable |
There was a problem hiding this comment.
I don't think the fallback channel is going to help here. stable is already the default but this variable is only used for a hab build and not installing missing hab components before entering the studio which is the case here.
I think (hope) the solution here is to leave HAB_BLDR_CHANNEL alone which will get the studio from stable. Then when it enters the studio and starts the build it will use HAB_INTERNAL_BLDR_CHANNEL to set HAB_BLDR_CHANNEL inside of the studio.
There was a problem hiding this comment.
@mwrock : Wondering if it's a better idea to pass HAB_STUDIO_SECRET_HAB_BLDR_CHANNEL and HAB_STUDIO_SECRET_HAB_FALLBACK_CHANNEL (both set to LTS-2024) env variables? This makes sure inside the studio accidentally stable does not get used at all?
There was a problem hiding this comment.
I am able to make progress in the build with the two env variables above, still seeing some issues, but don't look related to hab or studio
There was a problem hiding this comment.
Oh man I'm sorry. You are absolutely correct. HAB_STUDIO_SECRET_HAB_BLDR_CHANNEL was the correct variable. I'm not sure setting HAB_STUDIO_SECRET_HAB_FALLBACK_CHANNEL to stable will do anything because I think that is the default anyways.
There was a problem hiding this comment.
Nope: I meant setting HAB_STUDIO_SECRET_HAB_FALLBACK_CHANNEL to LTS-2024 so that, we know inside studio stable is not accidentally used somehow.
agadgil-progress
force-pushed
the
agadgil/lts-2024-node-updates
branch
from
3d4548c to
01064cb
Compare
|
@agadgil-progress you might consider adding |
Updated following dependencies - 1. NodeJS to version - 18.12.1 (available on LTS-2024) 2. `builder-web` dependencies - `webpack`, `node-sass` etc. 3. Removed not required `gcc`, `make` and `python2` from the `plan.sh` dependency Now at-least locally builds with `LTS-2024` channel and basic `make` and `make test` works locally Signed-off-by: Abhijit Gadgil <[email protected]>
Using `stable` as a fallback channel. Currently some of our own `hab` packages are not available on the `LTS-2024` channel. We are using this as a fallback channel for now. Signed-off-by: Abhijit Gadgil <[email protected]>
Using `HAB_SECRET_*` environment variables, this should make sure those environment variables are *only* set in `studio`, how we enter `studio` should not matter. This should help working with old versions of `studio` that are available only on `stable` in the CI Added `hab origin key generate habitat` Passing Node Options to make sure we use IPv4 Setting `NODE_OPTIONS` as HAB_SECRET_... env var Signed-off-by: Abhijit Gadgil <[email protected]>
agadgil-progress
force-pushed
the
agadgil/lts-2024-node-updates
branch
from
aa88b39 to
d8a51a6
Compare
|
@agadgil-progress should we merge this PR ? |
Yes, I had it planned yesterday, there is one small change I have to do because LTS-2024 channel upgraded |
|
Confirmed, this builds against |
Obvious fix; these changes are the result of automation not creative thinking.
Updated following dependencies -
builder-webdependencies -webpack,node-sassetc.gcc,makeandpython2from theplan.shdependencyNow at-least locally builds with
LTS-2024channel and basicmakeandmake testworks locally.Checking mileage with CI.