Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed OAuth error in github login for builder #1839

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

sougata-progress
Copy link
Contributor

@sougata-progress sougata-progress commented Sep 3, 2024

story : CHEF-15427

Copy link
Contributor

@mwrock mwrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mention what the actual fix was? Was it connected to sha2?

components/builder-api/src/server/mod.rs Outdated Show resolved Hide resolved
Signed-off-by: sougata-progress <[email protected]>
@sougata-progress sougata-progress force-pushed the sougata/git_login_bug_fix branch from f7cb278 to 88024b0 Compare September 3, 2024 22:33
@sougata-progress
Copy link
Contributor Author

The issue was with the sha2 crate version. 0.9.8 is yanked, and that paired with rust version 1.79 was creating the seg fault issue

@sougata-progress sougata-progress merged commit ffc9586 into main Sep 4, 2024
7 checks passed
@sougata-progress sougata-progress deleted the sougata/git_login_bug_fix branch September 4, 2024 11:53
chef-expeditor bot pushed a commit that referenced this pull request Sep 4, 2024
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants