Eula popup added #1842
Merged
Eula popup added #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AadeshNichite <[email protected]>
Signed-off-by: AadeshNichite <[email protected]>
|
@AadeshNichite If a user accepts the EULA during either sign-in or sign-up, do we need to show it again for the other option? Can you check with Product? |
Signed-off-by: AadeshNichite <[email protected]>
|
@sajjaphani I had a discussion with product regarding when to show Popup. We have to show popup at the time of sign in only. |
sajjaphani
approved these changes
Sep 20, 2024
chef-expeditor bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eula popup added while sign in and sign up
Related Tasks:
https://chefio.atlassian.net/browse/CHEF-13951
Screen.Recording.2024-09-10.at.5.13.18.PM.mov