Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubectl] Upgrade to k8s 1.14.3 #2657

Closed

Conversation

themightychris
Copy link
Contributor

This PR updates the standalone kubectl client package to the latest stable release

@themightychris themightychris requested a review from a team as a code owner June 13, 2019 02:42
@chef-expeditor
Copy link
Contributor

Hello themightychris! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Copy link
Collaborator

@predominant predominant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @themightychris thanks for the PR!

Would you mind including some testing steps to verify the build? Some great examples can be found here:

@james-stocks
Copy link

CHANGELOG-1.13.md and CHANGELOG-1.14.md mention a couple of breaking changes (kubernetes/kubernetes#70515 , kubernetes/kubernetes#72214 respectively)

The latter looks like it will affect very few people and the former looks like something affected users are just going to have to work through to get to the new version?

I don't have k8s experience to 👍 or 👎 based on this

@themightychris
Copy link
Contributor Author

@james-stocks is it within the purview of core-plans to worry about upstream breaking changes for client tools? This is the latest stable release client and the habitat plan delivers it in working order, it's needed for talking to newer clusters

@james-stocks
Copy link

@themightychris we have a wide variety of software in this repo and generally we do need to keep an eye out for breaking changes in minor releases.
But that needs to be balanced against making the versions that the world needs to use available; and I think you're right in this case (kubectl) that we need to move the version forward.

@predominant
Copy link
Collaborator

@themightychris Thanks for the PR, and sorry for the delay in replying. Could you please include some testing steps so we can verify the build?

@stale
Copy link

stale bot commented Jul 8, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used by stalebot to mark a pr as stale label Jul 8, 2020
@themightychris
Copy link
Contributor Author

themightychris commented Jul 8, 2020

@predominant added test in #3407

@themightychris themightychris deleted the update-k8s-1.14.3 branch July 8, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants