-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kubectl] Upgrade to k8s 1.14.3 #2657
[kubectl] Upgrade to k8s 1.14.3 #2657
Conversation
Signed-off-by: Chris Alfano <[email protected]>
Hello themightychris! Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @themightychris thanks for the PR!
Would you mind including some testing steps to verify the build? Some great examples can be found here:
CHANGELOG-1.13.md and CHANGELOG-1.14.md mention a couple of breaking changes (kubernetes/kubernetes#70515 , kubernetes/kubernetes#72214 respectively) The latter looks like it will affect very few people and the former looks like something affected users are just going to have to work through to get to the new version? I don't have k8s experience to 👍 or 👎 based on this |
@james-stocks is it within the purview of core-plans to worry about upstream breaking changes for client tools? This is the latest stable release client and the habitat plan delivers it in working order, it's needed for talking to newer clusters |
@themightychris we have a wide variety of software in this repo and generally we do need to keep an eye out for breaking changes in minor releases. |
@themightychris Thanks for the PR, and sorry for the delay in replying. Could you please include some testing steps so we can verify the build? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@predominant added test in #3407 |
This PR updates the standalone kubectl client package to the latest stable release