Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON and TOML template helpers #1024

Merged
merged 1 commit into from
Jul 1, 2016
Merged

JSON and TOML template helpers #1024

merged 1 commit into from
Jul 1, 2016

Conversation

smith
Copy link
Contributor

@smith smith commented Jul 1, 2016

Lets you do {{ json some.key }} or {{ toml some.key }} in your plans
and hooks.

This is for everybody who's ever written a .json.erb template in Chef.

gif-keyboard-6329082729284319389

Lets you do `{{ json some.key }}` or `{{ toml some.key }}` in your plans
and hooks.

This is for everybody who's ever written a .json.erb template in Chef.

Signed-off-by: Nathan L Smith <[email protected]>
@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @adamhjk, @reset, @fnichol, @metadave and @seth to be potential reviewers

@@ -120,6 +120,68 @@ like this:
host = host-2
port = 3434

## File format helpers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with adding to the docs

@reset
Copy link
Collaborator

reset commented Jul 1, 2016

@smith this is really great (and the perfect gif). Exactly what we needed, thank you!

gif-keyboard-2919983852698423725

@reset
Copy link
Collaborator

reset commented Jul 1, 2016

@thesentinels r+

1 similar comment
@smith
Copy link
Contributor Author

smith commented Jul 1, 2016

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit dbdfe32 has been approved by smith

@thesentinels
Copy link
Contributor

⌛ Testing commit dbdfe32 with merge 8a5232a...

thesentinels added a commit that referenced this pull request Jul 1, 2016
JSON and TOML template helpers

Lets you do `{{ json some.key }}` or `{{ toml some.key }}` in your plans
and hooks.

This is for everybody who's ever written a .json.erb template in Chef.

![gif-keyboard-6329082729284319389](https://cloud.githubusercontent.com/assets/9912/16511749/40f9535a-3f19-11e6-8fdf-26e75711a171.gif)
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit dbdfe32 into master Jul 1, 2016
@smith smith deleted the nls/hb-helpers branch July 1, 2016 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants