Stream output from running hooks #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix output streaming bug in standalone topology
|
This PR has passed 'Verify' and is ready for review and approval! |
|
You're using it fine. I'm not sure if that's the perfect output style, but it's fine for now. (In particular, it feels strange that it will say 'hook', rather than either bldr or the service name. But I'm not sure what it should be.) |
|
@delivery approve |
chef-delivery
added a commit
that referenced
this pull request
Nov 25, 2015
Merged change f111173e-aec3-4cde-9c7b-e31db4c1c943 From review branch stream-hook-output into master Signed-off-by: adam <[email protected]>
|
Change: f111173e-aec3-4cde-9c7b-e31db4c1c943 approved by: @adamhjk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is taken from our work on the multi-hana branch from week two at SAP in Germany. This change is still in the multi-hana branch but I'm submitting it here to ensure it gets into the codebase.
Additionally this fixes an output streaming bug in standalone topology.
@adamhjk can you check my usage of
output_format!here? I'm not 100% sure if I'm using it correctly!