fix package specificity in upload/configure commands #108
Conversation
fixes always retrieving latest package in upload/configure command when a version and release, or version is specified
| @@ -80,7 +80,7 @@ static LOGKEY: &'static str = "CS"; | |||
| /// * Fails if the `run` method for the topology fails | |||
| /// * Fails if an unknown topology was specified on the command line | |||
| pub fn package(config: &Config) -> BldrResult<()> { | |||
| match Package::latest(config.deriv(), config.package(), None, None) { | |||
| match Package::load(config.deriv(), config.package(), None, None, None) { | |||
There was a problem hiding this comment.
I uncovered a bit of poop here when I refactored. The behaviour here needs to be modified slightly now that we can specify version/release on the command line. We need to determine what the proper auto-update behaviour is if a version/release or just a version is specified on the command line.
|
This PR has passed 'Verify' and is ready for review and approval! |
1 similar comment
|
This PR has passed 'Verify' and is ready for review and approval! |
|
Seems like the right behavior is:
Adam |
|
@delivery approve |
Merged change 8b62156a-c6a9-4aa0-a535-0580303f90d0 From review branch exact-upload into master Signed-off-by: adam <[email protected]>
|
Change: 8b62156a-c6a9-4aa0-a535-0580303f90d0 approved by: @adamhjk |
|
@adamhjk that's the behaviour that I'm thinking, too. Let's start with that ;) |
Fixes always retrieving latest package in upload/configure command when a version and release, or version is specified