[bldr-build] Add pkg_build_deps and PATH fixes.
#109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Dependencies ------------------ This change introduces a new Plan variable: `pkg_build_deps`, also known as build dependencies. This is an array, similar to `pkg_deps` containing a list of packages needed to **build** the plan, but not to **run** the resulting package. For example, a Redis plan may have a build dependency on gcc and make. The dependency metadata is added to the package metadata and a new file `BUILD_DEPS` is also created. This gives bldr packages enough metadata to answer the following questions (previously difficult or impossible to determine): * What verion of gcc was I build with? * What version of musl was statically compiled into me? * What version of Go built this service? Remove gpg-zip Dependency ------------------------- Previously, a wrapping script `gpg-zip` was used to tar and gpg sign the resulting bldr package. This has been replaced with a comparable `tar ... | gpg ...` form which now only requires the `gpg` binary being present in the build environment. A future version of the build environment may add a statically built `gpg` binary to simplify the build dependency chain of `bldr-build` itself. Build-Time PATH Calculation --------------------------- This change prepends its own `pkg_binary_path` and all dependant build and runtime dependencies' `pkg_binary_path` to the current `PATH` before the build callbacks are invoked. The build dependencies' `PATH` entries will be added before the runtime dependencies, which is either the correct behavior or a future technical flaw (time will tell here).
|
|
|
This PR has passed 'Verify' and is ready for review and approval! |
| fi | ||
| done | ||
| # Insert all the package PATH fragments before the default PATH to ensure | ||
| # Bldr package binaries are used before any userland/operating system binaries | ||
| if [[ -n $path_part ]]; then |
|
This looks great. Useful functionality, well implemented - you pass the "can write shell" test. :)
|
|
@delivery approve |
|
Change: e38c8040-9cf4-4f2d-938b-139137eb9dc6 approved by: @adamhjk |
chef-delivery
added a commit
that referenced
this pull request
Dec 10, 2015
Merged change e38c8040-9cf4-4f2d-938b-139137eb9dc6 From review branch bldr-build-updates into master Signed-off-by: adam <[email protected]>
|
Yes, party time! 🍰 Wait for the next PR though, more shell writing 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build Dependencies
This change introduces a new Plan variable:
pkg_build_deps, also knownas build dependencies. This is an array, similar to
pkg_depscontaining a list of packages needed to build the plan, but not to
run the resulting package. For example, a Redis plan may have a
build dependency on gcc and make.
The dependency metadata is added to the package metadata and a new file
BUILD_DEPSis also created. This gives bldr packages enough metadatato answer the following questions (previously difficult or impossible to
determine):
Remove gpg-zip Dependency
Previously, a wrapping script
gpg-zipwas used to tar and gpg sign theresulting bldr package. This has been replaced with a comparable
tar ... | gpg ...form which now only requires thegpgbinary beingpresent in the build environment. A future version of the build
environment may add a statically built
gpgbinary to simplify thebuild dependency chain of
bldr-builditself.Build-Time PATH Calculation
This change prepends its own
pkg_binary_pathand all dependant buildand runtime dependencies'
pkg_binary_pathto the currentPATHbeforethe build callbacks are invoked. The build dependencies'
PATHentrieswill be added before the runtime dependencies, which is either the
correct behavior or a future technical flaw (time will tell here).