Document use of exec in run hooks #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mivok, thanks for your PR! By analyzing the annotation information on this pull request, we identified @cwebberOps, @davidwrede, @metadave, @stevendanna and @smith to be potential reviewers |
|
I spotted the need for a Signed-off-by thing. Fixing now. |
Fixes #989 Signed-off-by: Mark Harrison <[email protected]>
Signed-off-by: Mark Harrison <[email protected]>
|
@mivok this is great! thank you! |
|
📌 Commit 512c5be has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Aug 15, 2016
Fixes #989 Signed-off-by: Mark Harrison <[email protected]> Pull request: #1154 Approved by: metadave
thesentinels
pushed a commit
that referenced
this pull request
Aug 15, 2016
Signed-off-by: Mark Harrison <[email protected]> Pull request: #1154 Approved by: metadave
|
💥 Test timed out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change documents how you need to use exec in run hooks to avoid bad behavior, as well as providing a simple example and suggestions on when you would want to use a run hook instead of
$pkg_svc_run. Let me know if the reasons to use a run hook are incorrect and you could do those using$pkg_svc_runinstead.I also fixed a couple of links pointing to the hooks section.
This fixes #989