[bldr-build] Resolve and solve package dependencies once. #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change changes the behavior when referring to other package dependencies in a Plan. Packages will be "resolved" early in the building of a Plan, occurring after `bldr_begin()` and before `donwnload()`. Here being "resolved" simply means that a precise version of a package will be selected (and possibly installed if not present on disk) as the only version to be used by a Plan. Previously, `bldr-build` used the `latest_package()` function to get the approximate behavior, but there are potential races that could occur as new packages are installed by other processes. This modified strategy is to use the new `pkg_path_for()` Plan authors whenever previously using `latest_package()`. This has an added benefit of guarenteeing that the Plan will get a valid result everytime. If a Plan attempts to reference another package's path (via `pkg_path_for()`) which is not in the `$pkg_deps` or `$pkg_build_deps` arrays, this will abort the package build with an error message on standard error.
fnichol
changed the title
|
This PR has passed 'Verify' and is ready for review and approval! |
| REPO := http://159.203.235.47 | ||
|
|
||
| bldr: gpg | ||
| @for pkg in glibc libgcc zlib cacerts busybox patchelf libgpg-error libassuan gnupg gpgme openssl runit bldr; do \ | ||
| @for pkg in $(BLDR_PKGS); do \ |
|
I vetted these changes by running master's |
|
Another amazing Bash PR. You're the man. |
|
@delivery verify |
|
Failed to unknown change: cd77f944-1de2-456b-aa62-437657392daa |
|
@delivery approve |
chef-delivery
added a commit
that referenced
this pull request
Dec 16, 2015
Merged change cd77f944-1de2-456b-aa62-437657392daa From review branch bldr-build-resolve-deps-once into master Signed-off-by: adam <[email protected]>
|
Change: cd77f944-1de2-456b-aa62-437657392daa approved by: @adamhjk |
|
Oh noes, forgot the ritualistic GIF!
|
|
This PR has passed 'Acceptance' and is ready to be delivered! |
raskchanky
pushed a commit
that referenced
this pull request
Apr 16, 2019
Move ServiceBind implementation from Habitat repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change changes the behavior when referring to other package
dependencies in a Plan.
Packages will be "resolved" early in the building of a Plan, occurring
after
bldr_begin()and beforedonwnload(). Here being "resolved"simply means that a precise version of a package will be selected (and
possibly installed if not present on disk) as the only version to be
used by a Plan. Previously,
bldr-buildused thelatest_package()function to get the approximate behavior, but there are potential races
that could occur as new packages are installed by other processes.
This modified strategy is to use the new
pkg_path_for()Plan authorswhenever previously using
latest_package(). This has an added benefitof guaranteeing that the Plan will get a valid result everytime. If a
Plan attempts to reference another package's path (via
pkg_path_for())which is not in the
$pkg_depsor$pkg_build_depsarrays, this willabort the package build with an error message on standard error.