Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds access token scope to CLI #1189

Merged

Conversation

freethejazz
Copy link
Contributor

This simply adds a clarifying detail, that the access token only needs the user:email scope for setting up depot with GitHub authentication.

Signed-off-by: Jonathan Freeman [email protected]

This simply adds a clarifying detail, that the access token only needs the `user:email` scope for setting up depot with GitHub authentication.

Signed-off-by: Jonathan Freeman <[email protected]>
@thesentinels
Copy link
Contributor

@freethejazz, thanks for your PR! By analyzing the annotation information on this pull request, we identified @fnichol, @juliandunn, @metadave and @davidwrede to be potential reviewers

@reset
Copy link
Collaborator

reset commented Aug 25, 2016

@freethejazz Thanks for adding some clarity to the CLI for users, this should be good enough for now!

In the future I think we need something in our documentation instead and a link to it in our CLI. That way we can explain a bit more about why we need certain scopes and the list can expand if we add additional required or optional scopes

@reset reset merged commit b5174a3 into habitat-sh:master Aug 25, 2016
@freethejazz
Copy link
Contributor Author

There already is a bit of documentation in the getting started guide, but that might need to be augmented/moved to more a more general doc page: https://www.habitat.sh/tutorials/getting-started-setup-environment/ (see the Note: at the bottom of the page)

@reset
Copy link
Collaborator

reset commented Aug 26, 2016

@freethejazz I think you're right, we should call it out in a more general place. @davidwrede what do you think?

@davidwrede
Copy link

Agreed. I'll open an issue and assign to myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Flags an issue / PR for attention by the technical documentation team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants