Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for required metadata keys before build #1214

Merged
merged 1 commit into from
Sep 7, 2016

Conversation

miketheman
Copy link
Contributor

As of #910 we have documented the most basic requirements for a plan to
build.

Instead of repeating the same block for every variable we wish to test,
declare an array, and loop through to test if the value of the variable
is set to something not null.

Resolves #870

Signed-off-by: Mike Fiedler [email protected]

As of habitat-sh#910 we have documented the most basic requirements for a plan to
build.

Instead of repeating the same block for every variable we wish to test,
declare an array, and loop through to test if the value of the variable
is set to something not null.

Resolves habitat-sh#870

Signed-off-by: Mike Fiedler <[email protected]>
@miketheman
Copy link
Contributor Author

giphy

@reset
Copy link
Collaborator

reset commented Sep 7, 2016

gif-keyboard-8367724105754045200

Sorry for the late response, great work!

@reset reset merged commit 7f116b3 into habitat-sh:master Sep 7, 2016
@reset reset removed the In Progress label Sep 7, 2016
@miketheman miketheman deleted the miketheman/required-plan-vars branch September 7, 2016 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants