Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bldr-build] Only add runtime deps to LD_RUN_PATH. #122

Merged
merged 1 commit into from
Dec 22, 2015

Conversation

fnichol
Copy link
Collaborator

@fnichol fnichol commented Dec 22, 2015

This resolves an issue where build time dependencies were being added to
the RPATH/RUNPATH of ELF binaries.

This resolves an issue where build time dependencies were being added to
the RPATH/RUNPATH of ELF binaries.
@adamhjk
Copy link
Contributor

adamhjk commented Dec 22, 2015

This looks good. Ship it!

@fnichol
Copy link
Collaborator Author

fnichol commented Dec 22, 2015

gif-keyboard-1016331034452520340

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@adamhjk
Copy link
Contributor

adamhjk commented Dec 22, 2015

@delivery approve

chef-delivery added a commit that referenced this pull request Dec 22, 2015
Merged change 389aa1ce-2f15-431a-8bde-f8a760876f93

From review branch bldr-build-ld-run-path-deps-only into master

Signed-off-by: adam <[email protected]>
@chef-delivery chef-delivery merged commit e3a25ff into master Dec 22, 2015
@chef-delivery
Copy link
Contributor

Change: 389aa1ce-2f15-431a-8bde-f8a760876f93 approved by: @adamhjk

@chef-delivery chef-delivery deleted the bldr-build-ld-run-path-deps-only branch December 22, 2015 01:12
@chef-delivery
Copy link
Contributor

This PR has passed 'Acceptance' and is ready to be delivered!
Use: '@delivery deliver' when validated in acceptance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants