[hab,sup] Add UI#progress() method to control progress bar behavior.
#1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fnichol, thanks for your PR! By analyzing the annotation information on this pull request, we identified @metadave, @reset, @nsdavidson, @seth and @juliandunn to be potential reviewers |
|
|
|
Well, how about that? CI FTW--looks like I missed the director
|
This change adds a `progress()` method on the `UI` struct to determine
whether or not to display a progress bar on download/upload activities.
The decision is based on whether or not the stdout stream is a terminal
(i.e. an interactive session) meaning that progress bars will be removed
in non-interactive contexts.
Here is an example of the previous behavior (minus coloring which cannot
be reproduced here):
```
> /src/target/debug/hab install core/jq-static
» Installing core/jq-static
↓ Downloading core/jq-static/1.5/20160730001211
828.85 KB / 828.85 KB \ [====================================================] 100.00 % 462.36 KB/s
↓ Downloading core-20160612031944 public origin key
75 B / 75 B | [==============================================================] 100.00 % 824.83 KB/s
☑ Cached core-20160612031944 public origin key
✓ Installed core/jq-static/1.5/20160730001211
★ Install of core/jq-static/1.5/20160730001211 complete with 1 new packages installed.
```
Finally, here is the same command whose output stream is attached to a
unix pipe:
```
> /src/target/debug/hab install core/jq-static | cat
» Installing core/jq-static
↓ Downloading core/jq-static/1.5/20160730001211
↓ Downloading core-20160612031944 public origin key
☑ Cached core-20160612031944 public origin key
✓ Installed core/jq-static/1.5/20160730001211
★ Install of core/jq-static/1.5/20160730001211 complete with 1 new packages installed.
```
Signed-off-by: Fletcher Nichol <[email protected]>
fnichol
force-pushed
the
fnichol/interactive-progress-bar
branch
from
1097ec6 to
6a605a5
Compare
reset
approved these changes
Sep 14, 2016
Closed
christophermaier
added
Type: Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a
progress()method on theUIstruct to determinewhether or not to display a progress bar on download/upload activities.
The decision is based on whether or not the stdout stream is a terminal
(i.e. an interactive session) meaning that progress bars will be removed
in non-interactive contexts.
Here is an example of the previous behavior (minus coloring which cannot
be reproduced here):
Finally, here is the same command whose output stream is attached to a
unix pipe:
Signed-off-by: Fletcher Nichol [email protected]