Added plans for building apr and apr-util. #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has passed 'Verify' and is ready for review and approval! |
|
There is a plan step for install, so you don't have to include the make install in build (you'll win up calling make install twice). In the apr plan, there is no need for anything at - you should be able to delete do_build altogether, since it follows basic convention. |
| do_build() { | ||
| ./configure --prefix=${pkg_prefix} --with-apr=$(pkg_path_for chef/apr) | ||
| make | ||
| make install |
There was a problem hiding this comment.
You can remove this make install
|
This PR has passed 'Verify' and is ready for review and approval! |
|
@delivery approve |
chef-delivery
added a commit
that referenced
this pull request
Jan 3, 2016
Merged change bb262fe6-b304-40c9-a514-85cf9205128f From review branch jcd/apr-plan into master Signed-off-by: adam <[email protected]>
|
Change: bb262fe6-b304-40c9-a514-85cf9205128f approved by: @adamhjk |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote these plans to better understand
bldrand figured I might as well contribute them to the project for future use.