Always render run script with chpst #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes two primary changes to the build script: - The run script generated from pkg_svc_run in the plan will always render with chpst set to run with pkg_svc_user and pkg_svc_group - The generated run script no longer prefixes the pkg_svc_run command with "$pkg_prefix" These changes are necessary to ensure that the sane default for built packages does the right thing for the most cases. We assume that the binary used in the pkg_svc_run will be in a bin dir defined in the plan so it ends up in the PATH. Additionally, we need some other changes: - Update plans to reflect this change in the various components' plans - The proxy package can now use pkg_svc_run instead of having its own run hook Signed-off-by: jtimberman <[email protected]>
| if [[ -n "$pkg_svc_user" && "${pkg_svc_user}" != "root" ]]; then | ||
| cat <<EOT >> $pkg_prefix/run | ||
| # We use chpst to ensure that the script works outside `hab-sup` | ||
| # for debugging purposes, or under a `hab-director`. |
|
👍 |
reset
approved these changes
Sep 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes two primary changes to the build script:
render with chpst set to run with pkg_svc_user and pkg_svc_group
with "$pkg_prefix"
These changes are necessary to ensure that the sane default for built
packages does the right thing for the most cases. We assume that the
binary used in the pkg_svc_run will be in a bin dir defined in the plan
so it ends up in the PATH.
Additionally, we need some other changes:
run hook
Signed-off-by: jtimberman [email protected]