Make bootstrap tools an opt-in option when making chroot env. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces the `metal` Makefile targets with `chroot`. That is, `make metal`, `make metal-shell` and `make metal-destroy` have been replaced by `make chroot`, `make chroot-shell` and `make chroot-destroy` respectively. This change also alters the behavior of creating the chroot environments for Docker containers, virtual machines, and bare metal. Now, the tarballs required to populate the `/tools` directory are **not** added to the chroot, leaving a pristine environment with no foreign software. Until the basic build toolchain is complete (i.e. all software that is being used in `/tools`), this directory is still required and can be used by adding `use_bootstrap_tools=true` environment varible to the various `make` commands: * `make image use_bootstrap_tools=true` * `make vm use_bootstrap_tools=true` * `make chroot use_bootstrap_tools=true`
|
Metal, no?
|
|
This PR has passed 'Verify' and is ready for review and approval! |
|
@delivery approve |
chef-delivery
added a commit
that referenced
this pull request
Jan 7, 2016
Merged change 16fe1684-9df6-455b-9c03-d06d2401d64b From review branch chroot-optional-bootstrap-tools into master Signed-off-by: fnichol <[email protected]>
|
Change: 16fe1684-9df6-455b-9c03-d06d2401d64b approved by: @fnichol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the
metalMakefile targets withchroot. Thatis,
make metal,make metal-shellandmake metal-destroyhave beenreplaced by
make chroot,make chroot-shellandmake chroot-destroyrespectively.
This change also alters the behavior of creating the chroot environments
for Docker containers, virtual machines, and bare metal. Now, the
tarballs required to populate the
/toolsdirectory are not addedto the chroot, leaving a pristine environment with no foreign software.
Until the basic build toolchain is complete (i.e. all software that is
being used in
/tools), this directory is still required and can beused by adding
use_bootstrap_tools=trueenvironment varible to thevarious
makecommands:make image use_bootstrap_tools=truemake vm use_bootstrap_tools=truemake chroot use_bootstrap_tools=true