Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devshell] Use rustup in Dockerfile. #1257

Merged
merged 1 commit into from
Sep 19, 2016
Merged

Conversation

fnichol
Copy link
Collaborator

@fnichol fnichol commented Sep 18, 2016

This change "aggressively upgrades" us to use the new Rustup tooling
rather than the currently stable rustup.sh installer. Upon the release
of the next stable Rust, we should be able to drop the requirement of a
newer nightly Cargo installation further reducing the line count.

gif-keyboard-4040447348298661739

This change "aggressively upgrades" us to use the new Rustup tooling
rather than the currently stable rustup.sh installer. Upon the release
of the next stable Rust, we should be able to drop the requirement of a
newer nightly Cargo installation further reducing the line count.

Signed-off-by: Fletcher Nichol <[email protected]>
@thesentinels
Copy link
Contributor

@fnichol, thanks for your PR! By analyzing the annotation information on this pull request, we identified @metadave, @chetan, @reset, @jtimberman and @smith to be potential reviewers

@reset reset merged commit 65e5538 into master Sep 19, 2016
@reset reset deleted the fnichol/dockerfile-rustup branch September 19, 2016 08:58
@reset
Copy link
Collaborator

reset commented Sep 19, 2016

For anyone following along, the rustup project will replace the default installation instructions on rust-lang.org once it's finished. It also happens to be a successor to multirust which is a huge plus!

@eeyun eeyun added C-chore and removed Chore labels Jun 6, 2017
@christophermaier christophermaier added Type: Chore Issues for general code and infrastructure maintenance and removed C-chore labels Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Chore Issues for general code and infrastructure maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants