[hab/mac] Prompt for core origin key when performing a Mac hab release. #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change alters the ordering of the `mac-build.sh` script to prompt the user for a core origin signing key as soon as possible in the process. As a consequence, a `wget` command is no longer present for the mac `install.sh` program and therefore `curl` is used instead (Homebrew installs the `wget` command whereas `curl` is available on stock Mac installations). Signed-off-by: Fletcher Nichol <[email protected]>
|
@fnichol, thanks for your PR! By analyzing the annotation information on this pull request, we identified @reset and @juliandunn to be potential reviewers |
reset
approved these changes
Sep 19, 2016
christophermaier
added
Type: Chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change alters the ordering of the
mac-build.shscript to promptthe user for a core origin signing key as soon as possible in the
process. As a consequence, a
wgetcommand is no longer present for themac
install.shprogram and thereforecurlis used instead (Homebrewinstalls the
wgetcommand whereascurlis available on stock Macinstallations).