[Makefile] Repair serve-docs target & support Docker for Mac.
#1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the doc build paths to use the workspaces target path and also fixes the default/fallback URL for the web server to use `127.0.0.1` which is what the Docker for Mac app will use. Signed-off-by: Fletcher Nichol <[email protected]>
|
@fnichol, thanks for your PR! By analyzing the annotation information on this pull request, we identified @reset, @adamhjk, @jtimberman and @metadave to be potential reviewers |
christophermaier
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the doc build paths to use the workspaces target
path and also fixes the default/fallback URL for the web server to use
127.0.0.1which is what the Docker for Mac app will use.