move platform dependent calls from hab to core #1264
Conversation
wrap std::os::unix::ffi::OsStrExt and add a windows equal wrap std::os::unix::symlink and add a windows mock. There are windows symlink calls but they differ for file and directory. Signed-off-by: Steven Murawski <[email protected]>
| } | ||
| } | ||
|
|
||
| pub fn symlink<P: AsRef<Path>, Q: AsRef<Path>>(src: P, dst: Q) -> io::Result<()> { | ||
| unimplemented!(); |
There was a problem hiding this comment.
Are Junctions still a thing in Windows? How do they achieve symlinks these days (if at all)?
There was a problem hiding this comment.
Junctions are still a thing. the rust standard library has functions for the symlinks in windows, but they require you to determine if the source is a directory or file and call the specific function. Shouldn't be hard to implement here.
There was a problem hiding this comment.
Junctions can cross drive boundaries and are the only link type on windows that can do directory links. Hard links have to be on the same physical and logical volume and can only reference individual files.
https://msdn.microsoft.com/en-us/library/windows/desktop/aa365006(v=vs.85).aspx
|
Great work man, so excited for hab on Windows! |
christophermaier
added
Type: Feature
First steps to getting a functional hab command on Windows.
With this changeset, hab compiles but panics due to calling unimplemented user resolution from core.
ref: #1192
Signed-off-by: Steven Murawski [email protected]