Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation references for user scope #1271

Merged
merged 1 commit into from
Sep 22, 2016

Conversation

jtimberman
Copy link
Contributor

We need the user scope for the OAuth token, not just user:email.

Signed-off-by: jtimberman [email protected]

@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@davidwrede
Copy link

Thanks for doing the doc updates, @jtimberman!

We need the `user` scope for the OAuth token, not just `user:email`.

Signed-off-by: jtimberman <[email protected]>
@jtimberman
Copy link
Contributor Author

New and improved wording as to why we need user is in the latest commit here.
gif-keyboard-1552720110197943531

Copy link
Contributor

@adamhjk adamhjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@adamhjk
Copy link
Contributor

adamhjk commented Sep 21, 2016

@thesentinels approve

@thesentinels
Copy link
Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@adamhjk
Copy link
Contributor

adamhjk commented Sep 22, 2016

@thesentinels approve

@thesentinels
Copy link
Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@adamhjk
Copy link
Contributor

adamhjk commented Sep 22, 2016

@thesentinels approve

@thesentinels
Copy link
Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@adamhjk
Copy link
Contributor

adamhjk commented Sep 22, 2016

@thesentinels approve

@thesentinels
Copy link
Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@adamhjk
Copy link
Contributor

adamhjk commented Sep 22, 2016

@thesentinels approve

@thesentinels
Copy link
Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels
Copy link
Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit 820aaf4 into master Sep 22, 2016
@thesentinels thesentinels deleted the jtimberman/need-user branch September 22, 2016 20:42
@thesentinels
Copy link
Contributor

:neckbeard: Travis CI has started testing this PR.

@thesentinels
Copy link
Contributor

💔 Travis CI reports this PR failed to pass the test suite.

The next step is to examine the job and figure out why. If it is transient, you can try re-triggering the Travis CI Job - if it passes, this PR will be automatically merged. If it is not transient, you should fix the issue and update this pull request, and issue approve again. If you believe it will never pass, and you are feeling :godmode:, you can issue a force to merge this PR anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants