[plans] Add a ruby plan #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds dependencies for ruby: * libffi * libiconv * libtool * libyaml We needed to add the patch ruby-2_1_3-no-mkmf to prevent errors in make install. We also needed to force the openssl and libyaml directories by using the _resolve_dependency function from bldr-build.
|
This PR has passed 'Verify' and is ready for review and approval! |
1 similar comment
|
This PR has passed 'Verify' and is ready for review and approval! |
|
@jtimberman looks very clean! @delivery approve |
chef-delivery
added a commit
that referenced
this pull request
Jan 12, 2016
Merged change 467cfa25-2b4a-40d3-a18d-304d0ba2cf5a From review branch jtimberman/ruby-plan into master Signed-off-by: reset <[email protected]>
|
Change: 467cfa25-2b4a-40d3-a18d-304d0ba2cf5a approved by: @reset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds dependencies for ruby:
We needed to add the patch ruby-2_1_3-no-mkmf to prevent errors in make install. We also needed to force the openssl and libyaml directories by using the _resolve_dependency function from bldr-build.