Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Link to dependencies in package view #164

Merged
merged 1 commit into from
Jan 21, 2016
Merged

[web] Link to dependencies in package view #164

merged 1 commit into from
Jan 21, 2016

Conversation

smith
Copy link
Contributor

@smith smith commented Jan 21, 2016

Also:

  • Use webpack for JS bundle
  • Allow customizing appName
  • Have a "not found" page when you go to a package and it doesn't exist

(this includes the changes from #163, which hasn't been reviewed yet, so will need to be rebased when that happens.)

gif-keyboard-14988969196836315756

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

1 similar comment
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@reset
Copy link
Collaborator

reset commented Jan 21, 2016

@smith a package's dependencies are restricted down to their full package identifier which includes the version and release. I would recommend including that information and linking directly to those exact packages instead of the latest version/release of whatever dep they have

screen shot 2016-01-21 at 1 54 17 pm

@adamhjk
Copy link
Contributor

adamhjk commented Jan 21, 2016

Absolutely. Dependencies are always full, so you should display them that way.

Link to dependencies in package view
05dbeb0 
Also:

* Use webpack for JS bundle
* Allow customizing appName
* Have a "not found" page when you go to a package and it doesn't exist
@smith
Copy link
Contributor Author

smith commented Jan 21, 2016

Updated to show the full thing:

@smith smith changed the title Link to dependencies in package view [web] Link to dependencies in package view Jan 21, 2016
@reset
Copy link
Collaborator

reset commented Jan 21, 2016

gif-keyboard-1348696555493017544

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

1 similar comment
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@reset
Copy link
Collaborator

reset commented Jan 21, 2016

@delivery approve

chef-delivery added a commit that referenced this pull request Jan 21, 2016
@chef-delivery
Merge pull request #164 from chef/nls/dep-links
96a4357 
Merged change 67127609-92ff-40c8-813c-b1901386aa01

From review branch nls/dep-links into master

Signed-off-by: reset <[email protected]>
@chef-delivery chef-delivery merged commit 96a4357 into master Jan 21, 2016
@chef-delivery
Copy link
Contributor

Change: 67127609-92ff-40c8-813c-b1901386aa01 approved by: @reset

@chef-delivery chef-delivery deleted the nls/dep-links branch January 21, 2016 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smith @chef-delivery @reset @adamhjk